-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[CMake] Fix an RPath issue #20012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[CMake] Fix an RPath issue #20012
Conversation
Test Results 22 files 22 suites 3d 16h 36m 25s ⏱️ For more details on these failures, see this check. Results for commit f175cf6. ♻️ This comment has been updated with latest results. |
I have solved a similar problem in 47caba5 for TROOT, so |
5c30111
to
b31259b
Compare
@guitargeek I removed the changes to the path searching from this PR. I would need more time to rework this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks a lot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Usually, CMake automatically sets RUNPATH when target_link_libraries is used. However, since Core doesn't have other ROOT dependencies, its RUNPATH might only contain external dependencies or remain empty. To enable Core to find other ROOT libraries, its current location is added to its BUILD_RPATH.
b31259b
to
f175cf6
Compare
Usually, CMake automatically sets RUNPATH when target_link_libraries is
used. However, since Core doesn't have other ROOT dependencies, its
RUNPATH might only contain external dependencies or remain empty.
To enable Core to find other ROOT libraries, its current location is
added to its BUILD_RPATH.
If this isn't done, dlopen might find ROOT libraries which are installed in system locations.